Skip to content

Perf: Optimize performance of the get rows endpoints #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koc wants to merge 1 commit into
base: main
Choose a base branch
from
+1,052 −210
Open

Perf: Optimize performance of the get rows endpoints #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Share your tables and views with users and groups within your cloud.
Have a good time and manage whatever you want.

]]></description>
<version>2.4.0-dev.0</version>
<version>2.4.0-dev.1</version>
<licence>AGPL-3.0-or-later</licence>
<author>Nextcloud GmbH and Nextcloud contributors</author>
<namespace>Tables</namespace>
Expand Down Expand Up @@ -59,6 +59,12 @@ Have a good time and manage whatever you want.
<step>OCA\Tables\Migration\NewDbStructureRepairStep</step>
<step>OCA\Tables\Migration\DbRowSleeveSequence</step>
</post-migration>
<live-migration>
<step>OCA\Tables\Migration\CacheSleeveCells</step>
</live-migration>
<install>
<step>OCA\Tables\Migration\CacheSleeveCells</step>
</install>
</repair-steps>
<commands>
<command>OCA\Tables\Command\ListTables</command>
Expand Down
2 changes: 2 additions & 0 deletions lib/Config/ConfigLexicon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/
class ConfigLexicon implements ILexicon {
public const FEDERATION_ENABLED = 'federationEnabled';
public const CACHING_SLEEVE_CELLS_COMPLETE = 'cachingSleeveCellsComplete';

#[\Override]
public function getStrictness(): Strictness {
Expand All @@ -33,6 +34,7 @@ public function getStrictness(): Strictness {
public function getAppConfigs(): array {
return [
new Entry(self::FEDERATION_ENABLED, ValueType::BOOL, true, 'Enable or disable federated table sharing'),
new Entry(self::CACHING_SLEEVE_CELLS_COMPLETE, ValueType::BOOL, false, 'Cells of all rows have been cached into the row-sleeves table'),
];
}

Expand Down
4 changes: 2 additions & 2 deletions lib/Db/ColumnMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function findAll(array $id): array {

/**
* @param integer $tableId
* @return array
* @return Column[]
* @throws Exception
*/
public function findAllByTable(int $tableId): array {
Expand All @@ -117,7 +117,7 @@ public function findAllByTable(int $tableId): array {

/**
* @param integer $tableID
* @return array
* @return int[]
* @throws Exception
*/
public function findAllIdsByTable(int $tableID): array {
Expand Down
Loading
Loading