[nickvergessen]

Assisted-by: ClaudeCode:claude-opus-5-5

• Requires feat(emojis): Export emojiGetShortName nextcloud-libraries/nextcloud-vue#9146

☑️ Resolves

• Fix ???

AI (if applicable)

• The content of this PR was partly or fully generated using AI

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After
Emoji-only message
Reaction on message Might need a bit more fine tuning with long names
Reaction menu

• Inline message emojis were skipped for now:

  Emojis inside normal message text (hard): the text is rendered by NcRichText as markdown. To show a name on hover, each emoji would need its own around it, which would have to be done inside NcRichText (upstream) or by post-processing its output. That's real work and risks breaking the rendering.

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
  • Integrations with Files sidebar and other apps
  • Not risky to browser differences / client
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

[ShGKme]

Template shouldn't call functions in general:

• By design, it declares the result, not compute it. We don't control when and how this code is executed and only provide to the renderer rendering result declaration
• Functions may have side effects (appearing uncontrolled) of performance impacting entire rendering, blocking the thread

That's fine for small utils or formatting functions.

But getEmojiTitle is extremely low-performant function in the worst case due to EmojiIndex build, if it is the first run. We cannot guarantee, this call won't block entire app render for a second.

[ShGKme]

The best is to support async getEmojiTitle. Then it would support performant versions of the emoji functions when we refactor them.

[nickvergessen]

I tried that, but was not able to understand the resulting code in Talk anymore, with watchers being added to monitor the async responses and so on.
If that is really required someone needs to take over.

[nickvergessen]

I updated the Agetns.md with that hint never the less

[ShGKme]

If that is really required someone needs to take over.

To check if that's needed you can:

1. Check the first function call performance on the library side (so no other calls affect the result). If it's around 1 frame time (e.g. 10-20ms) - it is not a problem.
2. Check the same in spreed specifically. If the first getEmojiTitle call is fast, then we lost this time somewhere earlier already. In this case this function will only create a problem when we fix the existing one.

[ShGKme]

To have green CI and manual testing PR without local npm link, you can:

1. In the library npm run build && npm pack
2. In the app install built library npm i ../path/to/nextcloud-vue/nextcloud-vue-v9.x.x.tz
3. Commit (can be removed after library is released and bumped)

[ShGKme]

🏚️ Before	🏡 After
Reaction on message
Might need a bit more fine tuning with long names

And we need to fix the cut name

[ShGKme]

And we need to fix the cut name

To .reaction-details add overflow-wrap: anywhere;

[nickvergessen]

I'm unsure I get what problem is being solved.

Having reactions on your message and not being able to identify them

[nickvergessen]

Could you confirm, this is checked correct?

I checked it because from my POV there is nothing to clarify with Design and Nimisha is out for now

[Antreesy]

I would also expect NewMessage field and NcEmojiPicker to show such hints, but not the chat area and reactions popup. Other thing if we need that to be in aria-label for a11y?

[ShGKme]

Other thing if we need that to be in aria-label for a11y?

In theory, if the title represents the content (the same that we would put to aria-label and not an additional hint/description), we don't need it. Screen readers will use it as a label.

However, during BITV Test it was required to have aria-labels even if there is a title. If I remember that correctly.