Skip to content

chore: refactor last deprecated config methods - #20066

Draft
sudormant wants to merge 2 commits into
mainfrom
chore/noid/RefactorLastDeprecatedConfigMethods
Draft

sudormant wants to merge 2 commits into
mainfrom
chore/noid/RefactorLastDeprecatedConfigMethods

Conversation

@sudormant

Copy link
Copy Markdown
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@sudormant sudormant added this to the ☃️ Next Major (36) milestone Oct 30, 2026
@sudormant sudormant self-assigned this Oct 30, 2026
@sudormant sudormant added feature: settings ⚙️ Settings and config related issues technical debt labels Oct 30, 2026
@sudormant
sudormant force-pushed the chore/noid/RefactorLastDeprecatedConfigMethods branch from 92e7928 to c80f99b Compare November 2, 2026 10:38
Comment thread lib/Service/NoteToSelfService.php Outdated

protected function getNoteToSelfConversationId(string $userId): int {
return (int)$this->config->getUserValue($userId, 'spreed', 'note_to_self', '0');
return $this->userConfig->getValueInt($userId, Application::APP_ID, 'note_to_self', 0);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other places set and get a string

Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
@sudormant
sudormant force-pushed the chore/noid/RefactorLastDeprecatedConfigMethods branch from 1e6d7fe to 3327d12 Compare November 2, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: settings ⚙️ Settings and config related issues technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants