Skip to content

fix: add more sensitive parameter flags - #20053

Merged
nickvergessen merged 1 commit into
mainfrom
fix/noid/AddMoreSensitiveParameterFlags
Oct 30, 2026
Merged

nickvergessen merged 1 commit into
mainfrom
fix/noid/AddMoreSensitiveParameterFlags

Conversation

@sudormant

Copy link
Copy Markdown
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
@sudormant sudormant added this to the β›… Next Patch (35) milestone Oct 30, 2026
@sudormant sudormant self-assigned this Oct 30, 2026
@sudormant sudormant added the php label Oct 30, 2026
@sudormant
sudormant marked this pull request as ready for review October 30, 2026 08:16
'shareToken' => '.+',
])]
public function getRoomByShareToken(string $shareToken): DataResponse {
public function getRoomByShareToken(#[\SensitiveParameter] string $shareToken): DataResponse {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the URL so logged anyway

@nickvergessen
nickvergessen merged commit 55a79f5 into main Oct 30, 2026
77 checks passed
@nickvergessen
nickvergessen deleted the fix/noid/AddMoreSensitiveParameterFlags branch October 30, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants