Skip to content

chore(config): remove unused IConfig from constructors #20051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Oct 30, 2026
Merged

chore(config): remove unused IConfig from constructors #20051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/Chat/Changelog/Listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@
use OCP\AppFramework\Services\IAppConfig;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventListener;
use OCP\IConfig;

/**
* @template-implements IEventListener<Event>
*/
class Listener implements IEventListener {
public function __construct(
private readonly Manager $manager,
private readonly IConfig $serverConfig,
private readonly IAppConfig $appConfig,
) {
}
Expand Down
2 changes: 0 additions & 2 deletions lib/Files/TemplateLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use OCP\AppFramework\Services\IInitialState;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventListener;
use OCP\IConfig;
use OCP\IRequest;
use OCP\IUser;
use OCP\IUserSession;
Expand All @@ -30,7 +29,6 @@ class TemplateLoader implements IEventListener {
public function __construct(
private readonly IInitialState $initialState,
private readonly Config $talkConfig,
private readonly IConfig $serverConfig,
private readonly IAppConfig $appConfig,
private readonly IUserSession $userSession,
private readonly IRequest $request,
Expand Down
2 changes: 0 additions & 2 deletions lib/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
use OCP\DB\QueryBuilder\IQueryBuilder;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\ICache;
use OCP\IConfig;
use OCP\IDBConnection;
use OCP\IGroupManager;
use OCP\IL10N;
Expand All @@ -42,7 +41,6 @@
class Manager {
public function __construct(
private readonly IDBConnection $db,
private readonly IConfig $config,
private readonly Config $talkConfig,
private readonly IAppConfig $appConfig,
private readonly IAppManager $appManager,
Expand Down
2 changes: 0 additions & 2 deletions lib/MatterbridgeManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
use OCP\DB\QueryBuilder\IQueryBuilder;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\IAvatarManager;
use OCP\IConfig;
use OCP\IDBConnection;
use OCP\IURLGenerator;
use OCP\IUserManager;
Expand All @@ -43,7 +42,6 @@ class MatterbridgeManager {

public function __construct(
private readonly IDBConnection $db,
private readonly IConfig $config,
private readonly IAppConfig $appConfig,
private readonly IURLGenerator $urlGenerator,
private readonly IUserManager $userManager,
Expand Down
4 changes: 0 additions & 4 deletions lib/Signaling/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@
use OCA\Talk\CachePrefix;
use OCA\Talk\Config;
use OCA\Talk\Service\CertificateService;
use OCA\Talk\Service\RoomService;
use OCP\AppFramework\Http;
use OCP\AppFramework\Services\IAppConfig;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\Http\Client\IClientService;
use OCP\Http\Client\IResponse;
use OCP\ICache;
use OCP\ICacheFactory;
use OCP\IConfig;

class Manager {
public const FEATURE_HEADER = 'X-Spreed-Signaling-Features';
Expand All @@ -29,10 +27,8 @@ class Manager {
private readonly ICache $cache;

public function __construct(
private readonly IConfig $serverConfig,
private readonly IAppConfig $appConfig,
private readonly Config $talkConfig,
private readonly RoomService $roomService,
private readonly ITimeFactory $timeFactory,
private readonly IClientService $clientService,
private readonly CertificateService $certificateService,
Expand Down
1 change: 0 additions & 1 deletion tests/php/Controller/SignalingControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,6 @@ public function testLeaveRoomWithOldSession(): void {

$this->manager = new Manager(
$dbConnection,
\OCP\Server::get(IConfig::class),
$this->createMock(Config::class),
$appConfig,
\OCP\Server::get(IAppManager::class),
Expand Down
2 changes: 0 additions & 2 deletions tests/php/MatterbridgeManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public function setUp(): void {

$this->matterbridgeManager = new MatterbridgeManager(
$this->db,
$this->config,
$this->appConfig,
$this->url,
$this->userManager,
Expand Down Expand Up @@ -171,7 +170,6 @@ public function testDeleteBridgeOfRoomLogsCriticalAction(): void {
$matterbridgeManager = $this->getMockBuilder(MatterbridgeManager::class)
->setConstructorArgs([
$this->db,
$this->config,
$this->appConfig,
$this->url,
$this->userManager,
Expand Down
1 change: 0 additions & 1 deletion tests/php/Recording/BackendNotifierTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ public function setUp(): void {
$dbConnection = \OCP\Server::get(IDBConnection::class);
$this->manager = new Manager(
$dbConnection,
$config,
$this->config,
$this->appConfig,
\OCP\Server::get(IAppManager::class),
Expand Down
Loading