Skip to content

fix(CallView): show the camera of a selected screen sharer - #20041

Open
Antreesy wants to merge 2 commits into
mainfrom
fix/noid/selected-sharer-camera
Open

fix(CallView): show the camera of a selected screen sharer#20041
Antreesy wants to merge 2 commits into
mainfrom
fix/noid/selected-sharer-camera

Conversation

@Antreesy

@Antreesy Antreesy commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix Force promote user video should be prioritized over screenshare #11789
    • Selecting a participant who shares a screen now shows their camera in the main area and keeps their screen in the stripe.
    • Clicking the screen and "Show screen" in the stripe brings it back to the main area.
    • "Show screen" does nothing when that screen is already in the main area.
    • Drops hasSelectedScreen state, as a selection now always means the camera.

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (ClaudeCode:claude-opus-5-5)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
2026-10-29_15h46_16 2026-10-29_15h46_16
image 2026-10-29_15h46_26
2026-10-29_16h47_02 image
2026-10-29_16h47_09 image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
fix(CallView): show the camera of a selected screen sharer
7e01a97 
Selecting a participant who shares a screen now shows their camera in
the main area and keeps their screen in the stripe. Clicking the screen
in the stripe brings it back to the main area. "Show screen" does
nothing when that screen is already in the main area.

Drops the separate selected screen state, as a selection now always
means the camera.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(CallView): make the "Stop following" button easier to see
62cf0a8 
Use the secondary button variant without custom opacity and background,
and use the same "Stop following" label for the local video.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the ☃️ Next Major (36) milestone Oct 29, 2026
@Antreesy
Antreesy requested a review from ShGKme October 29, 2026 15:51
@Antreesy Antreesy self-assigned this Oct 29, 2026
@Antreesy Antreesy added bug feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Oct 29, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels

AI assisted This PR contains AI-assisted commits bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

☃️ Next Major (36)

Development

Successfully merging this pull request may close these issues.

Force promote user video should be prioritized over screenshare

2 participants

@Antreesy @nextcloud-command