Repository navigation
chore(config): simplify signaling_token_pub/privkey_* from wildcard to one dedicated appConfig value each, use dedicated and explicitly set signaling servers secret in method - #20031
Merged
Conversation
sudormant
added
feature: settings ⚙️
sudormant
marked this pull request as ready for review
October 28, 2026 15:34
…o one dedicated appConfig value each, use dedicated and explicitly set signaling servers secret in method Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
force-pushed
the
chore/noid/SimplifySignalingTokensConfig
branch
from
October 28, 2026 15:48
a1dabed to
69834ad
Compare
nickvergessen
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the signaling_token_privkey from the RoomController / getTalkHashHeader.
It already checks for the PubKey and assuming cryptography is not broken, a new pubkey belongs to a different privkey than before and thus can be assumed to have changed as well.
And if a different privkey derives to the same PubKey, it still can sign messages without needing a client reload.
The other way around, if a privkey changed but PubKey isn't checked, the PubKey will be a different one than before (if cryptography isn't broken, no two distinct private keys have the same public key).
🏁 Checklist
docs/has been updated or is not required