Skip to content

chore: Log error when direct dial-in was only found by using sip_brid… #20024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Oct 29, 2026
Merged

chore: Log error when direct dial-in was only found by using sip_brid… #20024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Controller/RoomController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2682,14 +2682,14 @@ public function directDialIn(string $phoneNumber, string $caller): DataResponse

try {
// Try to find the number with added dialout prefix as a fallback for old sip-bridges
// TODO: Log as error in 26, remove fallback and dialout prefix with 27
// TODO: Remove fallback and dialout prefix with 27
$entity = $this->phoneService->getAccountToCallForPhoneNumber($dialoutPrefix . $phoneNumber);
} catch (DoesNotExistException) {
$this->logger->info('No account found for direct dial-in with number: ' . $phoneNumber);
return new DataResponse(null, Http::STATUS_NOT_FOUND);
}

$this->logger->warning('Found account for direct dial-in only by adding the dial-out prefix. Please adjust the mapping for number: ' . $phoneNumber);
$this->logger->error('Found account for direct dial-in only by adding the dial-out prefix. This fallback will be removed in the next major version. Please adjust the mapping for number: ' . $phoneNumber);
}

$caller = trim($caller);
Expand Down
Loading