Skip to content

fix(LobbySettings): migrate to NcDateTimePickerNative - #20011

Merged
Antreesy merged 1 commit into
mainfrom
fix/8122/lobby-timepicker
Oct 26, 2026
Merged

fix(LobbySettings): migrate to NcDateTimePickerNative#20011
Antreesy merged 1 commit into
mainfrom
fix/8122/lobby-timepicker

Conversation

@Antreesy

@Antreesy Antreesy commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Replace last NcDateTimePicker with NcDateTimePickerNative
    • remove 5 minutes step (only validation in native pickers)
    • add minimal date-time validation
    • add 'Save' button as a guard (prevent instant submit on typing)
    • clear saved start time instantly via picker 'clearable' button
    • show error toast when saving start time fails
    • drop redundant icon
    • fix styles

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (ClaudeCode:claude-opus-5-5)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
fix(LobbySettings): migrate to NcDateTimePickerNative
faffcc0 
- remove 5 minutes step (only validation in native pickers)
- add minimal date-time validation
- add 'Save' button as a guard (prevent instant submit on typing)
- clear saved start time instantly via picker 'clearable' button
- show error toast when saving start time fails
- drop redundant icon
- fix styles

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the ☃️ Next Major (36) milestone Oct 26, 2026
@Antreesy
Antreesy requested a review from ShGKme October 26, 2026 13:04
@Antreesy Antreesy self-assigned this Oct 26, 2026
@Antreesy Antreesy added technical debt feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Oct 26, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Oct 26, 2026
@Antreesy
Antreesy merged commit be57aaa into main Oct 26, 2026
49 checks passed
@Antreesy
Antreesy deleted the fix/8122/lobby-timepicker branch October 26, 2026 13:21
@Antreesy

Antreesy commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@backportbot backportbot Bot mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels

AI assisted This PR contains AI-assisted commits feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby technical debt

Projects

None yet

Milestone

☃️ Next Major (36)

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @ShGKme @nextcloud-command