Repository navigation
fix: Mark session as inactive again after rejoin - #19872
Merged
Merged
Conversation
SystemKeeper
added
bug
feature: chat 💬
Member
|
@Antreesy can you have a look? |
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/background-inactive-session
branch
from
October 29, 2026 16:51
ddfd8c4 to
920bcec
Compare
Antreesy
approved these changes
Oct 29, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Rebased, refactored.
Known limitation circumvented with merging two watchers into one:
() => actorStore.sessionId acts now as a trigger, then same watcher check if token has changed -> and either marks inactive immediately or schedules it as before
Contributor
|
/backport to stable35 |
Contributor
|
/backport to stable34 |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Noticed today I did not receive messages of a conversation that was in an inactive tab. This happened after the laptop returned from standby.
A known limitation seems to be changing conversations in the background (e.g. with breakout rooms). That sounds like an acceptable limitation to me.AI (if applicable)
🏁 Checklist