Skip to content

fix(reaction): Mark one-to-one unread on reactions - #19867

Merged
nickvergessen merged 3 commits into
mainfrom
bugfix/noid/mark-one-to-one-unread-on-reaction
Oct 30, 2026
Merged

fix(reaction): Mark one-to-one unread on reactions#19867
nickvergessen merged 3 commits into
mainfrom
bugfix/noid/mark-one-to-one-unread-on-reaction

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Oct 16, 2026 •
edited by Antreesy
Loading

Copy link
Copy Markdown
Member

Assisted-by: ClaudeCode:claude-opus-5-5

Fixes

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Other side Self
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the ☃️ Next Major (36) milestone Oct 16, 2026
@nickvergessen nickvergessen self-assigned this Oct 16, 2026
@nickvergessen nickvergessen added papercut feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: reactions 👍 AI assisted This PR contains AI-assisted commits labels Oct 16, 2026
sudormant
sudormant approved these changes Oct 16, 2026
View reviewed changes

@sudormant sudormant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend OK in itself

@nickvergessen

This comment was marked as resolved.

Sign in to view
@nickvergessen

nickvergessen commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@Antreesy

This comment was marked as resolved.

Sign in to view
Antreesy
Antreesy reviewed Oct 19, 2026
View reviewed changes
Comment thread src/composables/useConversationInfo.ts Resolved
@nickvergessen
nickvergessen force-pushed the bugfix/noid/mark-one-to-one-unread-on-reaction branch from 3e8f917 to bcd4def Compare October 29, 2026 14:30
nickvergessen and others added 3 commits October 29, 2026 17:24
@nickvergessen @Antreesy
fix(reaction): Mark one-to-one unread on reactions
1164ab0 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@Antreesy
fix(reaction): Restore last message when reaction is removed in one-t…
59315d3 
…o-one

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(reaction): Update one-to-one last message from realtime reactions
b75d32c 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the bugfix/noid/mark-one-to-one-unread-on-reaction branch from bcd4def to b75d32c Compare October 29, 2026 16:26
Antreesy
Antreesy approved these changes Oct 29, 2026
View reviewed changes

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered revoking a reaction and UI update, when 1-1 chat is open (add/remove reaction).
Tested, but see PHP before merging

@nickvergessen
nickvergessen merged commit fa1f939 into main Oct 30, 2026
74 checks passed
@nickvergessen
nickvergessen deleted the bugfix/noid/mark-one-to-one-unread-on-reaction branch October 30, 2026 12:32
@backportbot backportbot Bot mentioned this pull request Oct 30, 2026
Open
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes
@sudormant sudormant sudormant approved these changes

Assignees

@nickvergessen nickvergessen

Labels

AI assisted This PR contains AI-assisted commits feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: reactions 👍 papercut

Projects

None yet

Milestone

☃️ Next Major (36)

Development

Successfully merging this pull request may close these issues.

Unread reaction in one-to-one / full subscribe should mark the conversation "unread"?

3 participants

@nickvergessen @Antreesy @sudormant