Repository navigation
[stable35] fix(matterbridge): validate the server domain for the matterbridge on each use to prevent DNS rebinding - #19824
Merged
Conversation
… each use to prevent DNS rebinding Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
backportbot
Bot
added
bug
feature: integration 📦
sudormant
approved these changes
Oct 13, 2026
|
|
||
| // check if current $bridge parts (domain) are still valid before doing anything | ||
| try { | ||
| $this->validateParts($bridge); // no return needed, validateParts will throw exception |
There was a problem hiding this comment.
I think this should be validateParts($bridge[parts]) otherwise validation always fails (on my machine at least.
$bridge looks like: ['enabled' => false, 'pid' => 0, 'parts' => []]
The validator only wants the [] inside 'parts'. (
spreed/lib/MatterbridgeManager.php
Lines 478 to 482 in eed360d
Contributor
There was a problem hiding this comment.
Hi, thank you very much for your report!
This indeed slipped my tests before, but I confirmed the parts is missing here.
I created a new PR and will backport:
#20052
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #19820