Repository navigation
[stable34] fix(call): return proper permission errors when starting a call is not allowed - #18672
Merged
Merged
Conversation
…ng a call The proxying server only accepted 200/400/404 from the host when joining a federated call. A 403 - returned by the host e.g. when start_calls restricts who may start calls and the federated participant is not allowed - was wrapped into a CannotReachRemoteException, so users saw what looked like a connection error instead of a permission error. Accept 403 as an expected status code, document it on the endpoint and regenerate the OpenAPI spec and types. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Pascal Kienast <info@pascalkienast.de>
… allowed When the signaling backend join path marks the first participant as in-call and that participant is not allowed to start the call, the ForbiddenException thrown by the RestrictStartingCalls listener escaped uncaught, so the HPB received an unstructured error instead of a proper backend error. SIP dial-in into a not-yet-started call is one way to reach this path. Catch the exception and return a structured 'start_call_not_allowed' backend error instead. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Pascal Kienast <info@pascalkienast.de>
backportbot
Bot
added
bug
feature: api 🛠️
…ll" settings Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/18664/stable34
branch
from
July 15, 2026 08:16
f266f70 to
4d2d53f
Compare
nickvergessen
marked this pull request as ready for review
July 15, 2026 10:30
nickvergessen
approved these changes
Jul 15, 2026
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18664
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.