Skip to content

fix(sip): Handle direct incoming calls as phone participants - #18567

Merged
SystemKeeper merged 16 commits into
mainfrom
bugfix/18123/handle-direct-incoming-calls-as-phone-participants
Oct 15, 2026
Merged

SystemKeeper merged 16 commits into
mainfrom
bugfix/18123/handle-direct-incoming-calls-as-phone-participants

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the ⛅ Next Major (35) milestone Jul 7, 2026
@nickvergessen nickvergessen self-assigned this Jul 7, 2026
@nickvergessen nickvergessen added bug feature: api 🛠️ OCS API for conversations, chats and participants feature: SFU & SIP ☎️ labels Jul 7, 2026
@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable34

Comment thread lib/Controller/RoomController.php Outdated
@SystemKeeper
SystemKeeper marked this pull request as draft September 18, 2026 16:07
@SystemKeeper
SystemKeeper force-pushed the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch 2 times, most recently from abe2713 to 5d1c49d Compare September 21, 2026 10:26
@SystemKeeper
SystemKeeper marked this pull request as ready for review September 22, 2026 09:26
@SystemKeeper

Copy link
Copy Markdown
Contributor

@nickvergessen Ready to check the latest code changes. Talked with @fancycode about it and seems fine for now. Will still do some tests with real sip bridge enabled.

@SystemKeeper

Copy link
Copy Markdown
Contributor

/backport to stable35

@nextcloud nextcloud deleted a comment from nickvergessen Sep 24, 2026
@nextcloud nextcloud deleted a comment from nickvergessen Sep 24, 2026
@SystemKeeper
SystemKeeper force-pushed the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch from a185133 to 7ccb9f1 Compare September 24, 2026 18:07
@SystemKeeper
SystemKeeper force-pushed the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch from 7ccb9f1 to 5992e23 Compare October 14, 2026 20:30
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Oct 14, 2026
@SystemKeeper
SystemKeeper force-pushed the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch from 5992e23 to a22b2af Compare October 14, 2026 20:31
@SystemKeeper

Copy link
Copy Markdown
Contributor

Final successful tests with the modified sipbridge (sending numbers as is, without stripping beginning "0"s):

  • Direct dial-in works fine with the assigned full number
  • A direct dial-in can be called back
  • Dial out is still working as expected
  • Migration worked and correctly skipped short numbers

Fix for federation CI in #19842

@SystemKeeper

Copy link
Copy Markdown
Contributor

/backport to stable33

nickvergessen and others added 16 commits October 15, 2026 09:05
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper force-pushed the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch from 8876270 to cbb72cd Compare October 15, 2026 07:07
@SystemKeeper

Copy link
Copy Markdown
Contributor

Waiting for CI fixes are backported with merge.

@SystemKeeper
SystemKeeper merged commit 51ff2cf into main Oct 15, 2026
77 of 79 checks passed
@SystemKeeper
SystemKeeper deleted the bugfix/18123/handle-direct-incoming-calls-as-phone-participants branch October 15, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits bug feature: api 🛠️ OCS API for conversations, chats and participants feature: SFU & SIP ☎️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dial-in room participant added as guest, not as a phone participant

5 participants