Skip to content

fix: restructure Talk integrations - #17940

Merged
Antreesy merged 3 commits into
mainfrom
fix/noid/integrations-structure
Oct 30, 2026
Merged

Antreesy merged 3 commits into
mainfrom
fix/noid/integrations-structure

Conversation

@Antreesy

@Antreesy Antreesy commented May 8, 2026 •

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Organize integration files
    • clean up src/ and src/views/ folders a bit
  • Keep main apps in src/
    • main (+ desktop)
    • recording
    • admin settings
  • Move regionCodes.js to utils
  • Fix mountpoint for PublicShareAuth (NC 36+)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (only validated)

File Restructuring: Before → After

BeforeAfter
src/
├── App.vue
├── RecordingApp.vue
├── icons.css
├── init.js
├── main.js
├── mainAdminSettings.js
├── mainRecording.js
├── collections.js
├── deck.js
├── flow.js
├── maps.js
├── search.js
├── mainFilesSidebar.js
├── mainFilesSidebarLoader.js
├── FilesSidebarLoaderApp.vue
├── FilesSidebarTabApp.vue
├── mainFloatingCall.ts
├── mainFloatingCallTrigger.ts
├── FloatingCallOverlay.vue
├── mainPublicShareSidebar.js
├── PublicShareSidebar.vue
├── PublicShareSidebarTrigger.vue
├── mainPublicShareAuthSidebar.js
├── publicShareAuthForm.ts
├── PublicShareAuthForm.vue
├── PublicShareAuthRequestPasswordButton.vue
├── PublicShareAuthSidebar.vue
├── regionCodes.js
├── views/
│   ├── AdminSettings.vue
│   ├── FilesSidebarCallView.vue
│   ├── FilesSidebarChatView.vue
│   ├── FlowPostToConversation.vue
│   └── (5 router views)
└── ...
src/
├── App.vue
├── AdminSettingsApp.vue
├── RecordingApp.vue
├── icons.css
├── init.js
├── main.js
├── mainAdminSettings.js
├── mainRecording.js
├── integrations/
│   ├── collections/
│   │   └── collections.js
│   ├── deck/
│   │   └── deck.js
│   ├── filesSidebar/
│   │   ├── mainFilesSidebar.js
│   │   ├── mainFilesSidebarLoader.js
│   │   ├── FilesSidebarCallView.vue
│   │   ├── FilesSidebarChatView.vue
│   │   ├── FilesSidebarLoaderApp.vue
│   │   └── FilesSidebarTabApp.vue
│   ├── floatingCall/
│   │   ├── mainFloatingCall.ts
│   │   ├── mainFloatingCallTrigger.ts
│   │   └── FloatingCallOverlay.vue
│   ├── flow/
│   │   ├── flow.js
│   │   └── FlowPostToConversation.vue
│   ├── maps/
│   │   └── maps.js
│   ├── publicShare/
│   │   ├── mainPublicShareSidebar.js
│   │   ├── PublicShareSidebar.vue
│   │   └── PublicShareSidebarTrigger.vue
│   ├── publicShareAuth/
│   │   ├── mainPublicShareAuthSidebar.js
│   │   ├── publicShareAuthForm.ts
│   │   ├── PublicShareAuthForm.vue
│   │   ├── PublicShareAuthRequestPasswordButton.vue
│   │   └── PublicShareAuthSidebar.vue
│   └── search/
│       └── search.js
├── utils/
│   ├── regionCodes.js
│   └── ...
├── views/
│   └── (5 router views)
└── ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Beta (34) milestone May 8, 2026
@Antreesy
Antreesy requested review from DorraJaouad and ShGKme May 8, 2026 14:38
@Antreesy Antreesy self-assigned this May 8, 2026
@Antreesy
Antreesy force-pushed the fix/noid/integrations-structure branch from 7dd54f1 to c462af1 Compare May 8, 2026 14:45
@Antreesy Antreesy changed the title fix: remove style loading for Talk integrations fix: restructure Talk integrations May 8, 2026
@DorraJaouad

Copy link
Copy Markdown
Contributor

Why you didn't place *main.js inside their correspondant folder?

@Antreesy
Antreesy force-pushed the fix/noid/integrations-structure branch from c462af1 to 334a3e4 Compare May 8, 2026 15:29
@Antreesy

Antreesy commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Why you didn't place *main.js inside their correspondant folder?

Correspondent folder only have helper files.
All actual entry-points are kept either at src/ or src/integrations, so rspack.config.js is less affected by renaming, and we have a full review from folder tree still

@DorraJaouad DorraJaouad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure makes sense IMO

@Antreesy
Antreesy force-pushed the fix/noid/integrations-structure branch from 334a3e4 to 56950b7 Compare October 30, 2026 09:32
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Oct 30, 2026
- Move entry points and root components of other apps integrations
  (Deck, Maps, Flow, Search, Collections, Files sidebar, public share,
  public share auth, floating call) to src/integrations/<name>/
- Keep src/views for router pages only
- Rename AdminSettings.vue to AdminSettingsApp.vue

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/integrations-structure branch from 56950b7 to c2cbaf0 Compare October 30, 2026 09:54
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Server no longer renders NcGuestContent with #guest-content-vue since
nextcloud/server@3b450df, so use
#core-public-share-auth and keep the old container as fallback.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/integrations-structure branch from c2cbaf0 to ffb06cd Compare October 30, 2026 09:55
@Antreesy
Antreesy merged commit 170f18f into main Oct 30, 2026
49 checks passed
@Antreesy
Antreesy deleted the fix/noid/integrations-structure branch October 30, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits feature: frontend 🖌️ "Web UI" client technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants