Skip to content

[stable33] fix(release): Use version var without leading v #17921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
May 5, 2026
Merged

[stable33] fix(release): Use version var without leading v #17921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/appstore-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
if: steps.krankerl.outputs.files_exists != 'true'
run: |
cd ${{ env.APP_NAME }}
make appstore version=${{ env.APP_VERSION }}
make appstore version=${{ fromJSON(steps.app-version.outputs.result).version }}

- name: Check server download link for ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/appstore-build-publish.yml.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ index 31086eaf2f..16834c4893 100644
run: |
cd ${{ env.APP_NAME }}
- make appstore
+ make appstore version=${{ env.APP_VERSION }}
+ make appstore version=${{ fromJSON(steps.app-version.outputs.result).version }}

- name: Check server download link for ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
run: |
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ appstore:
--exclude=webpack.config.js \
$(project_dir)/ $(sign_dir)/$(app_name)
@if [ -f $(project_dir)/docs/changelogs/changelog-$(firstword $(subst ., ,$(version))).md ]; then \
cp $(project_dir)/docs/changelogs/changelog-$(firstword $(subst ., ,$(version))).md $(sign_dir)/$(app_name)/CHANGELOG.md; \
cp -v $(project_dir)/docs/changelogs/changelog-$(firstword $(subst ., ,$(version))).md $(sign_dir)/$(app_name)/CHANGELOG.md; \
else \
echo "changelog-$(firstword $(subst ., ,$(version))).md not found"; \
fi
@if [ -f $(cert_dir)/$(app_name).key ]; then \
echo "Signing app files…"; \
Expand Down
Loading