Repository navigation
fix: Reject login with NUL bytes rather than converting - #66193
Merged
Merged
Conversation
come-nc
requested review from
Altahrim,
CarlSchwan,
cristianscheid,
marcoambrosini,
salmart-dev and
sorbaugh
and removed request for
a team
November 3, 2026 13:38
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-login-nul-byte
branch
from
November 3, 2026 13:39
90c1709 to
f3ce964
Compare
cristianscheid
approved these changes
Nov 3, 2026
nickvergessen
approved these changes
Nov 3, 2026
Altahrim
approved these changes
Nov 3, 2026
artonge
approved these changes
Nov 3, 2026
artonge
left a comment
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Small question but fine either way
come-nc
enabled auto-merge
November 3, 2026 14:43
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
come-nc
added
4. to release
Contributor
Author
|
Not sure why the last job got canceled, but this is good to merge. |
AndyScherzinger
disabled auto-merge
November 3, 2026 22:09
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It makes no sense to strip them.
Checklist
3. to review, feature component)stable32)AI (if applicable)