Skip to content

refactor(settings): migrate password, WebAuthn and language sections to Vue 3 - #66179

Merged
susnux merged 6 commits into
masterfrom
refactor/settings-personal-vue3
Nov 4, 2026
Merged

refactor(settings): migrate password, WebAuthn and language sections to Vue 3#66179
susnux merged 6 commits into
masterfrom
refactor/settings-personal-vue3

Conversation

@pringelmann

@pringelmann pringelmann commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Migrates the password, WebAuthn and language & locale sections to Vue 3.

  • Dropped moment, the locale example and first day of week use Intl now
  • Firefox < 153 has no Intl week info, so there the "Derived from your locale" option shows the user's chosen first day instead of the locale default
  • New e2e test for changing the password

Manually tested

  • Password change, including a rejected wrong password and logging in with the new one
  • WebAuthn: adding, deleting and logging in with a device
  • Language, locale, first day of week and time zone each still set after a reload
  • Locale example format and the “derived from your locale” label, including the browser fallback

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@pringelmann pringelmann self-assigned this Nov 3, 2026
@pringelmann pringelmann added feature: settings technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 3, 2026
@pringelmann pringelmann added this to the Nextcloud 36 milestone Nov 3, 2026
@pringelmann
pringelmann force-pushed the refactor/settings-personal-vue3 branch from 2b79836 to 86df464 Compare November 3, 2026 13:44
@pringelmann
pringelmann marked this pull request as ready for review November 3, 2026 13:51
@pringelmann
pringelmann requested review from a team as code owners November 3, 2026 13:51
@pringelmann
pringelmann requested review from kristian-zendato, skjnldsv and susnux and removed request for a team November 3, 2026 13:51
@pringelmann pringelmann added the 3. to review Waiting for reviews label Nov 3, 2026
@come-nc
come-nc removed their request for review November 4, 2026 08:53
susnux
susnux reviewed Nov 4, 2026
View reviewed changes
Comment thread apps/settings/src/sections/password/main.ts Resolved
susnux
susnux approved these changes Nov 4, 2026
View reviewed changes

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good and not a blocker, but two small comments left:

  • structure of new vue files
  • folder structure of the settings app

@pringelmann
pringelmann force-pushed the refactor/settings-personal-vue3 branch from e758631 to b2dedba Compare November 4, 2026 12:46
@pringelmann @susnux
test(settings): cover changing the password
75d9528 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann @susnux
refactor(settings): migrate password, WebAuthn and language sections …
b4c60b5 
…to Vue 3

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann @susnux
refactor(settings): simplify the migrated personal sections
2df7c51 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann @susnux
refactor(settings): match master's time zone picker and drop lodash
72d869b 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann @susnux
refactor(settings): migrate the personal sections to script setup
f397eaa 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann @susnux
refactor(settings): move migrated sections under sections and put scr…
18f7dd0 
…ipt first

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@susnux
susnux force-pushed the refactor/settings-personal-vue3 branch from b2dedba to 18f7dd0 Compare November 4, 2026 14:06
@susnux

susnux commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

(rebased due to conflicts - no changes)

@susnux
susnux merged commit bdbb2f9 into master Nov 4, 2026
144 checks passed
@susnux
susnux deleted the refactor/settings-personal-vue3 branch November 4, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato is a code owner automatically assigned from nextcloud/server-frontend
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@pringelmann pringelmann

Labels

3. to review Waiting for reviews AI assisted feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@pringelmann @susnux @CarlSchwan