Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: lazerg <lazerg2@gmail.com>
lazerg
requested review from
Altahrim,
icewind1991,
leftybournes and
sorbaugh
and removed request for
a team
November 3, 2026 10:16
Contributor
|
See #66169 that was used instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a lazy ghost's initializer throws and the exception gets logged,
encodeArg()callsget_object_vars()on the still uninitialized ghost from the trace args. That runs the initializer again, and the new exception escapes the logger, which is what breaksocc upgradeinSchemaCheckerfor disabled apps on PHP 8.4.Uninitialized lazy objects are now logged with only their class name, so the initializer never runs from the logger. Added a test that fails before the change.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)