Repository navigation
[stable35] fix(files_external): reset EOF when seeking in SFTPReadStream - #66166
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
Once a read reached the end of the remote file, the eof flag stayed set after a seek, and every later read returned an empty string. The movie preview reads the moov atom at the end of a video and then copies the file from the start, so the sparse file was all zeros and ffmpeg failed. Fixes #66001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tiago Carrondo <tiago@carrondo.pt>
backportbot
Bot
added
bug
3. to review
provokateurin
approved these changes
Nov 3, 2026
provokateurin
enabled auto-merge
November 3, 2026 07:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #66002