Skip to content

fix(dav): compare room seating capacity numerically - #66118

Open
lazerg wants to merge 1 commit into
nextcloud:masterfrom
lazerg:fix/issue-64413-room-capacity-numeric
Open

lazerg wants to merge 1 commit into
nextcloud:masterfrom
lazerg:fix/issue-64413-room-capacity-numeric

Conversation

@lazerg

@lazerg lazerg commented Oct 31, 2026 •

Copy link
Copy Markdown

Summary

The room seating capacity search compared the stored varchar value as a string, so a 100-seat room was dropped when searching for at least 2 seats. The column is now cast to an integer before the comparison.

TODO

  • Compare seating capacity as an integer

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (Claude, claude-opus-5-5)

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: lazerg <lazerg2@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Nov 2, 2026
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Nov 2, 2026
@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 36 milestone Nov 2, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@lazerg Please put back the original PR description templete and fill it in properly

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

/backport to stable35

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

/backport to stable34

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

/backport to stable33

@lazerg

lazerg commented Nov 2, 2026

Copy link
Copy Markdown
Author

Done, I restored the template and filled it in.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Room search filters seating capacity as a string, dropping rooms that fit

2 participants