Repository navigation
fix(core): remove apple-touch-icon-precomposed - #66050
Open
bulungasdeveloper wants to merge 1 commit into
Open
bulungasdeveloper wants to merge 1 commit into
bulungasdeveloper wants to merge 1 commit into
Conversation
bulungasdeveloper
requested review from
Altahrim,
CarlSchwan,
kristian-zendato,
pringelmann,
provokateurin,
salmart-dev and
skjnldsv
and removed request for
a team
October 30, 2026 19:42
Since iOS 7, apple-touch-icon is already treated as precomposed, so the extra apple-touch-icon-precomposed link only duplicated the same favicon-touch.png in the head of every page. Keep a single apple-touch-icon and mask-icon in both the user and the public layouts, and cover them with a Playwright head regression spec. Assisted-by: opencode:deepseek-v4.1-flash-free Signed-off-by: Braux Martinez <martinezjb@hitss.com>
bulungasdeveloper
force-pushed
the
fix/remove-apple-touch-icon-precomposed
branch
from
October 30, 2026 20:12
ec217f4 to
a00e635
Compare
skjnldsv
approved these changes
Oct 31, 2026
skjnldsv
enabled auto-merge
October 31, 2026 03:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
core/templates/layout.user.phpandcore/templates/layout.public.phpemitrel="apple-touch-icon"andrel="apple-touch-icon-precomposed"pointing to thesame
favicon-touch.png.apple-touch-icon-precomposedhas been deprecated since iOS 7, whereapple-touch-iconis already treated as precomposed. The extra link onlyduplicates the entry in
<head>, and since browsers resolve the last matchingrel, the resulting icon depends on tag order rather than intent.This drops the deprecated link in both layouts and keeps
apple-touch-icontogether with the theming
mask-icon, which is unrelated and untouched.TODO
Checklist
tests/playwright/e2e/core/page-head.spec.tsasserts asingle
apple-touch-icon, no-precomposed, and onemask-iconin theuser and the public layout
<head>onlystable35/stable33AI