Skip to content

fix(sharing): configure which shares of disabled accounts are hidden - #66037

Draft
ArtificialOwl wants to merge 1 commit into
masterfrom
fix/63159/disabled-user-shares
Draft

ArtificialOwl wants to merge 1 commit into
masterfrom
fix/63159/disabled-user-shares

Conversation

@ArtificialOwl

@ArtificialOwl ArtificialOwl commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

This is draft on fixing #63159

Summary

  • returns to previous default behavior,
  • allow to disable local and/or external shares using a scope,
  • previous config is deprecated, converted via migration step

TODO

  • Admin documentation for core/hide_disabled_user_shares_scope

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Oct 30, 2026
@ArtificialOwl ArtificialOwl added this to the Nextcloud 36 milestone Oct 30, 2026
@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable35

@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable34

@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable33

@susnux susnux left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit over-complicated, why not just add second option to allow a different behavior on internal shares?
Would be a ~10 lines change then.

returns to previous default behavior,

❌ No this is not possible, the change was on purpose and has to stay.

@ArtificialOwl

ArtificialOwl commented Oct 30, 2026 •

Copy link
Copy Markdown
Member Author

seems a bit over-complicated, why not just add second option to allow a different behavior on internal shares? Would be a ~10 lines change then.

That was my previous work, but the logic were strange:

  • one to hide all (default),
  • one to hide external with admin needing to disable the first one,

therefor the use of scope seemed better.
Should I switch back to a 2 settings solution ?

returns to previous default behavior,

❌ No this is not possible, the change was on purpose and has to stay.

ok, wanted confirmation it was on purpose :)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants