Repository navigation
Conversation
PublicAuth::check() converted every unexpected exception into a ServiceUnavailable, including the NotFound thrown for a share token that does not exist (anymore), e.g. after the share was deleted by reaching its download limit. Clients got a 503 and every such request was logged as an error. Let NotFound pass through and also map the ShareNotFound from the strict cookie check to a NotFound, registering a brute force attempt like checkToken() does. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
Altahrim,
GhassenKefi,
leftybournes,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team,
salmart-dev and
sorbaugh
October 29, 2026 17:39
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublicAuth::check() converted every unexpected exception into a ServiceUnavailable, including the NotFound thrown for a share token that does not exist (anymore), e.g. after the share was deleted by reaching its download limit.
Checklist
3. to review, feature component)stable32)AI (if applicable)