Repository navigation
Conversation
Since the theming app data was scoped into the "global" folder, `ImageManager::cleanup()` listed the cache-buster folders through `ISimpleFolder::getDirectoryListing()`, which only returns files. So outdated cache folders were never removed. Add `ISimpleFolder::getFolderListing()` to list the sub folders of a simple folder and use it for the cleanup. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
`Util::getAppImage()` removed `..` and backslashes from the requested path and additionally tried the path with several image extensions appended. So many different paths resolved to the same file. Reject such paths instead and only resolve the exact path. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
come-nc,
icewind1991,
leftybournes and
sorbaugh
and removed request for
a team
October 29, 2026 16:54
susnux
commented
Oct 29, 2026
| * @return ISimpleFolder[] | ||
| * @since 36.0.0 | ||
| */ | ||
| public function getFolderListing(): array; |
Contributor
Author
There was a problem hiding this comment.
I am not sure we really want to have this here, I felt like its easier to have it in the interface then always do this in application code.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Smaller issues found while I was working on an other theming related issue.
Checklist
3. to review, feature component)stable32)AI (if applicable)