Repository navigation
[stable35] test(avatar): Check the guest avatar independent of the font renderer - #66017
Merged
Merged
Conversation
GuestAvatarTest::testGet() compared the generated PNG byte for byte with a stored image. The anti-aliasing of the letter depends on the GD and FreeType versions: the stored image matches Ubuntu 24.04 (libgd3 2.3.3-9ubuntu5, FreeType 2.13.2), while Ubuntu 26.04 (libgd3 2.3.3-13ubuntu2, FreeType 2.14.2) and the bundled GD of the official PHP images render a few edge pixels differently. The nodb jobs therefore fail whenever they run on a runner with the newer image. Check the PNG format, the image size and the guest background color in the light and the dark theme instead, and count the pixels in the letter color: the anti-aliased edges differ between renderers, the strokes of the letter don't. Also remove the SVG fixture, which has been unused since guest avatars switched to PNG. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
backportbot
Bot
requested review from
Altahrim and
DerDreschner
and removed request for
a team
October 29, 2026 16:49
backportbot
Bot
added
3. to review
DerDreschner
approved these changes
Oct 29, 2026
DerDreschner
enabled auto-merge
October 29, 2026 16:50
provokateurin
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #65954