Repository navigation
Conversation
When sharing is disabled for a user, their home storage loses the share permission, so validateMoveOrCopy() refuses to move or copy any of their files into a folder that has a shared ancestor, even when source and target are covered by the same share and no new recipient gains access. The new unit and integration tests for moves within such a share fail until this is fixed. Tests for moves that do expose the file to new recipients (a share not covering the source, a reshare by a recipient, a received share) document the behavior that has to be kept. Refs: #65433 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
When sharing is disabled for a user, the sharing_mask wrapper strips the share permission from their home storage. validateMoveOrCopy() then refused every move or copy of their files into a folder with a shared ancestor, even when source and target are below the same share. Handle sources on the user's home storage like share-ownerless mounts: only refuse the operation when it exposes the node to new recipients. Look up shares including reshares, so shares created by recipients on subfolders of the user's own share are still taken into account. Fixes: #65433 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
come-nc,
icewind1991,
salmart-dev and
sorbaugh
and removed request for
a team
October 29, 2026 16:44
susnux
requested review from
GhassenKefi and
provokateurin
and removed request for
salmart-dev and
sorbaugh
October 29, 2026 16:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When sharing is disabled we still should be able to move files within the same share.
Checklist
3. to review, feature component)stable32)AI (if applicable)