Skip to content

fix(core): drop unused bruteforce_attempts_ip index - #66000

Open
GhassenKefi wants to merge 2 commits into
masterfrom
fix/bruteforce-drop-ip-index
Open

GhassenKefi wants to merge 2 commits into
masterfrom
fix/bruteforce-drop-ip-index

Conversation

@GhassenKefi

@GhassenKefi GhassenKefi commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Brute force attempts are only looked up and reset by subnet, and the cleanup job filters on the occurred column. No query filters on ip, so the index only adds write overhead on every registered attempt.

Fixes #49841

Assisted-by: ClaudeCode:claude-opus-5-5

  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Brute force attempts are only looked up and reset by subnet, and the
cleanup job filters on the occurred column. No query filters on ip, so
the index only adds write overhead on every registered attempt.

Fixes #49841

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
@GhassenKefi
GhassenKefi requested a review from a team as a code owner October 29, 2026 08:25
@GhassenKefi
GhassenKefi requested review from Altahrim and removed request for a team October 29, 2026 08:25
@GhassenKefi GhassenKefi self-assigned this Oct 29, 2026
@GhassenKefi GhassenKefi added the 3. to review Waiting for reviews label Oct 29, 2026
@GhassenKefi
GhassenKefi requested a review from susnux October 29, 2026 08:26

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is needed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove from the old index where this was added

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. the failing test i think it's a test issue not something relevent to what i pushed

Fresh installs no longer create the index, and the migration test is
dropped as it only covered a trivial schema change.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unnecessary index bruteforce_attempts_ip

4 participants