Skip to content

feat(files): report files opened locally as opened - #65995

Merged
skjnldsv merged 1 commit into
masterfrom
feature/open-locally-report-opened
Oct 29, 2026
Merged

skjnldsv merged 1 commit into
masterfrom
feature/open-locally-report-opened

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Summary

"Open locally" now reports the file through the new opened API once the desktop client was asked to open it. We can't know if the client actually did, only that it was asked. A retry doesn't count twice. "Open online" reports nothing here, the viewer does that itself when it opens the file.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv self-assigned this Oct 29, 2026
@skjnldsv
skjnldsv added this pull request to stack #65996 October 29, 2026 03:08
@skjnldsv
skjnldsv marked this pull request as ready for review October 29, 2026 06:55
Base automatically changed from feature/node-opened-event to master October 29, 2026 15:32
"Open locally" now reports the file through the opened API once the
desktop client was asked to open it, retried or not. "Open online"
leaves it to the viewer, which reports what it opens itself.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the feature/open-locally-report-opened branch from abd7c3f to 24cb9d9 Compare October 29, 2026 15:32
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 29, 2026
@skjnldsv
skjnldsv merged commit 0ac628a into master Oct 29, 2026
90 of 92 checks passed
@skjnldsv
skjnldsv deleted the feature/open-locally-report-opened branch October 29, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants