Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Mario Alfonso Pym Mejía <pymm@hitss.com>
MarioPym
requested review from
Altahrim,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
October 28, 2026 23:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #49476,
AUserDataOCSController::fillStorageInfo()reads the used space from the home storage root (''). On local storage, this works becauseHomeCacheoverrides the root size with the size offiles/. However,HomeObjectStoreStoragedoes not useHomeCache, meaning that when S3 is used as primary storage, the root size improperly includesfiles_trashbin,files_versions, anduploads.Consequently,
GET /ocs/v2.php/cloud/users/<uid>reports inflated quota usage (sometimes resulting in negative free space), whereas quota enforcement (Quotawrapper,root => 'files') correctly counts onlyfiles/. This causes mobile clients to incorrectly display accounts as full.This PR changes the controller to read the cache entry of the user folder (
files) directly. For local home storage, the resulting value remains identical.Note: DAV
quota-used-bytes(viaOC_Helper::getStorageInfo()) shares this issue on object stores because it also queries the cache for''. MakingHomeObjectStoreStorageutilizeHomeCachelikeHomewould resolve both issues. I have kept this PR scoped strictly to the provisioning API, but I am happy to open a separate PR for the storage layer if that is the preferred direction.How to test
GET /ocs/v2.php/cloud/users/<uid>:used10485924,free-164,relative100used3145892,free7339868,relative30Checklist
3. to review, feature component)stable32)AI (if applicable)