Repository navigation
Improve file-cache search performance for large caches - #65986
Open
Daddyoftwins1 wants to merge 3 commits into
Open
Daddyoftwins1 wants to merge 3 commits into
Daddyoftwins1 wants to merge 3 commits into
Conversation
Daddyoftwins1
requested review from
Altahrim,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
October 28, 2026 16:24
Assisted-by: Codex:gpt-6.1-sol Signed-off-by: Josh Duffy <joshduff.jd@gmail.com>
Assisted-by: Codex:gpt-6.1-sol Signed-off-by: Josh Duffy <joshduff.jd@gmail.com>
Daddyoftwins1
force-pushed
the
prep/bounded-files-search-master
branch
from
October 28, 2026 16:45
4037466 to
9389000
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves file-cache search performance for the tested large-cache workloads while preserving the compared search results and maintaining compatibility with the current upstream architecture.
The changes update the search implementation for current connection handling and sharding, integrate optional indexes into Nextcloud's native missing-index lifecycle, and add upstream-native regression tests.
Performance
The patched implementation was compared with unchanged Nextcloud 36 development code at the same commit. The controlled synthetic benchmark used 100,000 target files and approximately 504,000 total cache rows.
Selected warm-cache median results:
All search results compared within the benchmark fixture matched. Adding indexes alone did not produce a consistent material improvement in this experiment; the search implementation changes were necessary for the measured gains.
These are controlled synthetic benchmarks. Performance will vary with cache size, workload, and environment. The small-cache slowdown is a known tradeoff.
Validation
Please review the search implementation, optional-index lifecycle, connection and sharding compatibility, and regression coverage.
AI assistance
I was assisted by Codex AI with implementation, automated testing, benchmarking, and code review.
Evidence
Code and benchmark evidence bundle