Skip to content

fix(files_sharing): encode path in public share download redirect #65983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarioPym wants to merge 1 commit into
base: master
Choose a base branch
from
+44 −1
Open

fix(files_sharing): encode path in public share download redirect #65983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/files_sharing/lib/Controller/ShareController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
use OCP\Share\IManager as ShareManager;
use OCP\Share\IPublicShareTemplateFactory;
use OCP\Share\IShare;
use OCP\Util;

/**
* @package OCA\Files_Sharing\Controllers
Expand Down Expand Up @@ -391,7 +392,7 @@ public function downloadShare(string $token, ?string $files = null, string $path

$davPath = '';
if ($node !== $share->getNode()) {
$davPath = substr($node->getPath(), strlen($share->getNode()->getPath()));
$davPath = Util::encodePath(substr($node->getPath(), strlen($share->getNode()->getPath())));
}

$params = [];
Expand Down
42 changes: 42 additions & 0 deletions apps/files_sharing/tests/Controller/ShareControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\ContentSecurityPolicy;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Http\RedirectResponse;
use OCP\AppFramework\Http\Template\ExternalShareMenuAction;
use OCP\AppFramework\Http\Template\LinkMenuAction;
use OCP\AppFramework\Http\Template\PublicTemplateResponse;
Expand Down Expand Up @@ -752,6 +753,47 @@ public function testDownloadShareWithoutDownloadPermission(): void {
$this->assertEquals($expectedResponse, $response);
}

public static function dataDownloadShareRedirectEncodesPath(): array {
return [
'plain folder' => ['folder', null, 'folder', '/public.php/dav/files/validtoken/folder?accept=zip'],
'hash in folder' => ['a#b', null, 'a#b', '/public.php/dav/files/validtoken/a%23b?accept=zip'],
'nested special chars' => ['sub dir/50% ?x', null, 'sub dir/50% ?x', '/public.php/dav/files/validtoken/sub%20dir/50%25%20%3Fx?accept=zip'],
'legacy file name' => ['', 'notes #1.txt', 'notes #1.txt', '/public.php/dav/files/validtoken/notes%20%231.txt'],
];
}

#[\PHPUnit\Framework\Attributes\DataProvider(methodName: 'dataDownloadShareRedirectEncodesPath')]
public function testDownloadShareRedirectEncodesPath(string $path, ?string $files, string $relativePath, string $expectedUrl): void {
$target = $files === null ? $this->createMock(Folder::class) : $this->createMock(File::class);
$target->method('getPath')->willReturn('/owner/files/shared/' . $relativePath);

$shareNode = $this->createMock(Folder::class);
$shareNode->method('isReadable')->willReturn(true);
$shareNode->method('isShareable')->willReturn(true);
$shareNode->method('getPath')->willReturn('/owner/files/shared');
$shareNode->method('get')
->with($files ?? $path)
->willReturn($target);

$share = $this->createMock(IShare::class);
$share->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
$share->method('getNode')->willReturn($shareNode);

$this->shareManager
->method('getShareByToken')
->with('validtoken')
->willReturn($share);

$this->urlGenerator->expects(self::once())
->method('getAbsoluteURL')
->with($expectedUrl)
->willReturn('https://cloud.example.com' . $expectedUrl);

$response = $this->shareController->downloadShare('validtoken', $files, $path);
$this->assertInstanceOf(RedirectResponse::class, $response);
$this->assertSame('https://cloud.example.com' . $expectedUrl, $response->getRedirectURL());
}

public function testDisabledOwner(): void {
$this->shareController->setToken('token');

Expand Down
Loading