Repository navigation
test(dav): make principal search assertions order-independent - #65970
Open
joshtrichards wants to merge 1 commit into
Open
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
CalDAV principal search does not guarantee result ordering, but testSearchPrincipal compared returned calendar data by array index. Compare normalized payloads canonically instead, so the test verifies the expected results without depending on database row order. Cover both the user's results and the sharer's results. Resolves #37321 Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
SebastianKrupinski and
tcitworld
as code owners
October 27, 2026 14:36
joshtrichards
added
the
⚠️ risk: low
Member
|
CS is now failing 🙈 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I didn't experience this, but
testSearchPrincipal()assumed that CalDAV principal search results are returned in database-ID order, which the API does not guarantee.Changes:
This is a test-only fix; production search behavior is unchanged.
Out of scope: CalDAV
searchPrincipalUri()supportslimitandoffset, but its paginated ID query has no explicit ordering. That can make page membership inconsistent; a follow-up fix should probably define the order before applying pagination.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)