Skip to content

fix(versions): empty array for external shares #65801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leftybournes wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

fix(versions): empty array for external shares #65801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/files_versions/lib/Versions/LegacyVersionsBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Exception;
use OC\Files\View;
use OCA\DAV\Connector\Sabre\Exception\Forbidden;
use OCA\Files_Sharing\External\Storage as ExternalShareStorage;
use OCA\Files_Versions\Db\VersionEntity;
use OCA\Files_Versions\Db\VersionsMapper;
use OCA\Files_Versions\Storage;
Expand Down Expand Up @@ -74,6 +75,10 @@ public function getVersionsForFile(IUser $user, FileInfo $file): array {
if (!$file) {
throw new NotFoundException('version file not found for share owner');
}
} elseif ($storage->instanceOfStorage(ExternalShareStorage::class)) {
$this->logger->info('Version files not available for external shares');

return [];
} else {
$userFolder = $this->rootFolder->getUserFolder($user->getUID());
}
Expand Down
Loading