Repository navigation
feat(login-flow): warn when a login flow was started from another network - #65740
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
nickvergessen
approved these changes
Oct 23, 2026
…work Login flow v2 now remembers the address that started a flow (new nullable column login_flow_v2.initiator_ip). When the flow is granted from another network of the same IP family, the grant page warns the user that someone may be trying to get access to their account, which is what a phishing link to someone else's login flow looks like. A switch between IPv4 and IPv6 does not count, as that is common on dual-stack devices. After a flow is granted, LoginFlowV2GrantedEvent is dispatched with the new app password, the starting address and the start time, so apps can react, e.g. by notifying the user. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
karlitschek
force-pushed
the
feat/login-flow-v2-initiator-address
branch
from
October 25, 2026 19:40
71d77b2 to
b661c28
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of seven small, independent core changes needed by a planned
intrusion_detectionapp. Each can be reviewed and merged on its own:AppPasswordCreatedEvent, dispatched everywhereIProvider::invalidateTokenById()in the public token providerShareLinkAccessFailedEventPasswordResetRequestedEventIChallengeRequester: ask for the second factor again in a sessionlogin_flow_v2.initiator_ip(migrationVersion36000Date20261020200000) and bumpsversion.phpto 36.0.0.1.IEventDispatchertoLoginFlowV2Service; whichever merges second needs a trivial rebase.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an
Assisted-bytrailer.🤖 Generated with Claude Code