Repository navigation
fix(sharebymail): Send readable password by mail instead of hash - #65576
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
requested review from
Altahrim,
CarlSchwan,
salmart-dev and
sorbaugh
and removed request for
a team
October 16, 2026 09:49
Member
Author
|
/backport to stable35 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues, and regression tests cover the changed behavior; tests were not executed.
0 open findings
What changed in this PR
Fixes #65479 by sending readable share-by-mail passwords while preserving hashed passwords in storage.
Changes:
- Retains caller-provided plaintext passwords for email notifications.
- Handles generated passwords and prevents mailing password hashes.
- Adds regression tests for password storage and notification behavior.
| File | Description |
|---|---|
| tests/lib/Share20/ManagerTest.php | Tests plaintext notifications and hashed return values. |
| lib/private/Share20/Manager.php | Passes plaintext passwords through a notification-only share clone. |
| apps/sharebymail/tests/ShareByMailProviderTest.php | Tests supplied hashes, generated passwords, and hash suppression. |
| apps/sharebymail/lib/ShareByMailProvider.php | Preserves generated plaintext for notification and skips mailing hashes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nickvergessen
approved these changes
Oct 16, 2026
ChristophWurst
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since ee1feb8 (which was backported to stable35 with #64892 ), the sent passwords when using share-by-mail are hashes and not the plaintext passwords anymore. This is kinda intentional, as the providers themselves should now only contain hashed passwords. To fix that, the manager itself needs to keep the plaintext password and use that when mailing the receiver of a share.
This PR also fixes code that Claude detected as dead in later iterations, but as I plan to do a backport, I'll remove that in a separate PR.
Checklist
3. to review, feature component)stable32)AI (if applicable)