Skip to content

[stable32] fix(systemtags): update file node on tag assignment - #65337

Merged
susnux merged 2 commits into
stable32from
fix/noid/system-tags-event
Oct 13, 2026
Merged

susnux merged 2 commits into
stable32from
fix/noid/system-tags-event

Conversation

@Antreesy

@Antreesy Antreesy commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: UI reactivity

Summary

To reproduce:

  • Open details -> Actions menu -> Tags
  • Assign existing or create a new tag for the file
  • See chip appear on FileRow
  • File actions -> Manage tags
  • See tags are not selected there
Before After
image image

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Antreesy Antreesy self-assigned this Oct 9, 2026
@Antreesy
Antreesy requested a review from a team as a code owner October 9, 2026 10:11
@Antreesy
Antreesy requested review from kristian-zendato, pringelmann and susnux and removed request for a team October 9, 2026 10:11

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but why not master + stable backports?

@Antreesy

Antreesy commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Code looks good, but why not master + stable backports?

stable33 and recent do not longer have this issue (with specified reproduction steps), targeting only affected branch

@Antreesy

Copy link
Copy Markdown
Contributor Author

/compile rebase

@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport! cd21e71 to stable31

Antreesy and others added 2 commits October 13, 2026 10:12
- systemtags:node:updated only affect the chips appearance on a FileRow
- files:node:update also propagate changes to 'Manage tags' dialog

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the fix/noid/system-tags-event branch from cd21e71 to 547a291 Compare October 13, 2026 10:15
@susnux
susnux merged commit 79f908b into stable32 Oct 13, 2026
141 of 150 checks passed
@susnux
susnux deleted the fix/noid/system-tags-event branch October 13, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants