Repository navigation
Conversation
|
Really not sure about this. Else we have to create an app folder again for viewer |
susnux
left a comment
There was a problem hiding this comment.
I am not sure its a good thing we move more of viewer into lib.
Maybe rollback and make apps/viewer again a force enabled app to separate concerns here making it cleaner on where to put this.
Maybe a minimal viewer app is necessary indeed. But this is also frustrating, there is no clean way to have libs register user settings without some php scafolding 😤😤 |
faa949b to
90f125e
Compare
|
@susnux, alright, done! I didn't use the provisioning api event-based approach in the end, I don't know, don't like it 🙈 |
59ba09b to
3e5b699
Compare
apps/viewer becomes a minimal, always enabled app again, the server side of the viewer. It keeps the user's viewer settings the way the Files app keeps its own: a UserConfig service listing the allowed keys, an OCS endpoint to change one, and the settings handed to the viewer as initial state. They are the slideshow delay, and the volume of videos and audio and whether they start muted. Core keeps loading the viewer itself. It is no longer an abandoned app to clean up after, and continues the old app's versions at 9.0.0-dev.0, after 8.0.0 in 35. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
3e5b699 to
5e9b016
Compare
Summary
The viewer library now has a settings dialog (nextcloud-libraries/nextcloud-viewer#136), and remembers the volume of videos and audio. These settings are stored on the server.
Following review,
apps/vieweris a minimal, always enabled app again, the server side of the viewer. It already held theOCA.Viewershim and the deprecatedLoadViewerevent. It now also keeps the user's viewer settings, the way the Files app keeps its own: aUserConfigservice listing the allowed keys, an OCS endpoint to change one, and the settings handed to the viewer as theviewer/configinitial state, for logged-in users only. They are the slideshow delay (1 to 60 seconds), the volume (0 to 100) and whether media start muted.Core keeps loading the viewer itself. The app is back in
shipped.jsonwhere it was before #63954, and off the abandoned apps the repair step cleans up. It continues the old app's versions at 9.0.0-dev.0, where nextcloud/viewer's master stood after 8.0.0 in 35, so an instance upgrading from 35 updates it like any other app.The endpoint takes JSON:
valueis a number or a boolean depending on the setting, and the framework doesn't cast a union from form data.Checked on a fresh install and on one with the old viewer's
installed_version8.0.0, whichocc upgradeupdates to 9.0.0-dev.0.Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.