Repository navigation
Conversation
00226fe to
e422c7e
Compare
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Blocking until design approves
|
@kra-mo thoughts? |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Looked at the failing checks ( @SebastianKrupinski noted, I won't push further changes here until the design question to @kra-mo is resolved — not making any assumptions about the wording decision. Happy to adjust the strings once there's guidance. |
…correctly Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
e422c7e to
625ac39
Compare
|
Can you please put back the original PR template and fill it out properly |
Summary
Fix CalDAV activity wording when multiple events are merged into one activity entry.
Subjects used a literal word “event” before the
{event}placeholder (You created event {event}…). AfterEventMergerexpands{event}to{event1} and {event2}, that read as “You created event A and B…”.Align with the files activity pattern (
You created {file}) so the placeholder is the event name(s). Merged activities then read naturally: “You created A and B in calendar …”.Closes #5528
Test plan
Event.phpAI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.