Repository navigation
fix(files_versions): offer comparing versions wherever the viewer can - #65225
Merged
Merged
Conversation
Comparing was offered for pictures only, waiting for the viewer to say which of its handlers compare. @nextcloud/viewer 2.0.0-beta.15 does, through canCompare(): Text can compare two versions again, as it could with the old viewer app. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
kristian-zendato,
sorbaugh and
susnux
and removed request for
a team
October 6, 2026 19:12
5 of 6 tasks
skjnldsv
requested review from
artonge
and removed request for
a team and
sorbaugh
October 6, 2026 19:48
mejo-
approved these changes
Oct 7, 2026
silverkszlo
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The versions tab offered "Compare to current version" for pictures only: its comment said the viewer package did not yet say which handlers compare.
@nextcloud/viewer2.0.0-beta.15 does, throughcanCompare(), so this bumps it and asks it. Text setscanCompareon its handler (nextcloud/text#9235), so markdown and text files can be compared again, as they could with the old viewer app. Text's "Versions › Compare" end-to-end test needs it.The phone rule stays: two versions side by side need the width.
The bump also brings beta.15's other fixes; its changelog is in nextcloud-libraries/nextcloud-viewer#113.
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.