Repository navigation
fix: improve invitation mail building - #64942
Open
SebastianKrupinski wants to merge 1 commit into
Open
SebastianKrupinski wants to merge 1 commit into
SebastianKrupinski wants to merge 1 commit into
Conversation
Contributor
Author
|
/backport to stable35 |
SebastianKrupinski
requested review from
DerDreschner,
GVodyanov,
hamza221,
kesselb and
odzhychko
September 30, 2026 15:35
SebastianKrupinski
marked this pull request as ready for review
September 30, 2026 15:37
SebastianKrupinski
requested review from
ChristophWurst and
tcitworld
as code owners
September 30, 2026 15:37
DerDreschner
approved these changes
Oct 15, 2026
SebastianKrupinski
requested review from
Altahrim,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
October 29, 2026 14:49
kesselb
approved these changes
Oct 29, 2026
SebastianKrupinski
force-pushed
the
fix/improve-invitation-mail-building
branch
from
October 29, 2026 14:58
4a95088 to
1721045
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/improve-invitation-mail-building
branch
from
October 29, 2026 16:09
1721045 to
ede158c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is more of a refactor but i'm framing it as a fix so it can be back ported
Moved all mail building functionality in to iMipService
Split mail building in to 3 distinct methods one for each type "Request, Reply, Cancel"
Checklist
3. to review, feature component)stable32)AI (if applicable)