[theroch]

• Resolves: # Support webcal http auth & store credentials calendar#70

Summary

parse_url() does not decode percent-encoded characters, so special characters (e.g. '#', '@', ':') in the credentials must be decoded before use, or Basic-Auth sends the raw url-encoded sequence instead of the real password.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[ChristophWurst]

From nextcloud/calendar#70

The credentials are stored in the source column in oc_calendarsubscriptions, so this is still a security gap.

Dropping this here so the implication is transparent for reviewers

[SebastianKrupinski]

Hi @theroch

Thank you for the PR, but as this was only a partial fix for the credential issue I decided it would be faster to just make a fix for this.

So closing this in favour of #65705

[github-actions]

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com