feat(files): Make Files app reusable by tomek2k1 · Pull Request #64692 · nextcloud/server

tomek2k1 · 2026-09-23T14:23:59Z

There is a need to display files in other apps (e.g. Teams) in the same way as in the Files app, including all available features. This is the first step toward making the Files view available in other apps.

Assisted-by: Copilot:Claude-Sonnet-5

Resolves: Display the team’s Files app embedded within the Teams app. circles#2663

Summary

TODO

...

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

marcoambrosini · 2026-10-07T09:47:56Z

@tomek2k1, @artonge is available if you're stuck or need some guidance on this :)

github-actions · 2026-10-08T01:53:21Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de> Assisted-by: Copilot:Claude-Sonnet-5

artonge

Looks good overall!

artonge · 2026-10-22T09:10:15Z

+		throw new Error('Only one embedded Files view can be active at a time')
+	}
+
+	const router = createFilesRouter(createMemoryHistory())


Do we have use cases where this is not createMemoryHistory()?
If not, then maybe we can drop the argument and hard code it in the function.

artonge · 2026-10-22T09:11:48Z

+	}
+
+	const router = createFilesRouter(createMemoryHistory())
+	const previousRouterService = window.OCP.Files.Router


Why do we need to save the previous router service?

artonge · 2026-10-22T09:13:52Z


-		routerHookRegistered = true
-		window.OCP.Files.Router._router.afterEach((to, from) => {
+		hookedRouter = router


Why do we need to save the router here?

artonge · 2026-10-22T09:21:38Z

+	<component
+		:is="embedded ? 'div' : 'NcAppContent'"
+		v-bind="embedded ? {} : { pageHeading }"
+		:class="{ 'app-content': embedded }"
+		data-cy-files-content>


In order to have a distinctive class name. Because other apps use a similar class for their own app content, so their could be some conflict when injecting the files app in those.

Suggested change

<component

:is="embedded ? 'div' : 'NcAppContent'"

v-bind="embedded ? {} : { pageHeading }"

:class="{ 'app-content': embedded }"

data-cy-files-content>

<component

:is="embedded ? 'div' : 'NcAppContent'"

v-bind="embedded ? {} : { pageHeading }"

:class="files-app-content"

data-cy-files-content>

The new class name could then be used to replace .app-content where you already changed it from main.app-content.

Yes this makes sense!

susnux · 2026-10-22T09:34:00Z

+ * app's own controller. It triggers the same script/initial-state bootstrap
+ * that `files.view.index` performs.
+ */
+class LoadFilesApp extends Event {


As we only want loading the files list not the real app I would say call it LoadFilesList

susnux · 2026-10-22T09:35:54Z

+		Util::addInitScript('files', 'init');
+		Util::addScript('files', 'main');


Please use Application::APP_ID here instead of string hardcoded 'files', thats the style we use for every new file

susnux · 2026-10-22T09:39:42Z

 }

+// Expose the ability to render the Files UI on a foreign page
+window.OCP.Files.renderFilesApp ??= renderFilesView


I would say no new OCP frontend API here but use OCA and expose it in nextcloud/files library.

susnux

Should also get a review of @skjnldsv as app owner

tomek2k1 added the AI assisted label Sep 23, 2026

tomek2k1 self-assigned this Sep 23, 2026

tomek2k1 added this to 👥 Teams Sep 23, 2026

github-project-automation Bot moved this to Backlog in 👥 Teams Sep 23, 2026

tomek2k1 moved this from Backlog to In progress in 👥 Teams Sep 23, 2026

tomek2k1 added this to the Nextcloud 36 milestone Sep 23, 2026

tomek2k1 mentioned this pull request Sep 23, 2026

feat(files): Make Files app reusable #63461

Closed

1 of 8 tasks

tomek2k1 force-pushed the feature/files-app4all branch from 76547fb to 99ef95d Compare September 23, 2026 14:27

tomek2k1 removed the status in 👥 Teams Sep 23, 2026

tomek2k1 moved this to In progress in 👥 Teams Sep 23, 2026

tomek2k1 force-pushed the feature/files-app4all branch from 99ef95d to 062c83e Compare September 24, 2026 07:28

tomek2k1 changed the title ~~feat(files): Make Files app reusable~~ WIP feat(files): Make Files app reusable Oct 3, 2026

marcoambrosini requested a review from artonge October 7, 2026 09:46

skjnldsv added 2. developing Work in progress team: Files Code maintained by 📁 Files team labels Oct 7, 2026

github-actions Bot added the feedback-requested label Oct 8, 2026

tomek2k1 force-pushed the feature/files-app4all branch 2 times, most recently from ab07ffd to bcaa42e Compare October 8, 2026 15:52

tomek2k1 changed the title ~~WIP feat(files): Make Files app reusable~~ feat(files): Make Files app reusable Oct 8, 2026

tomek2k1 marked this pull request as ready for review October 8, 2026 16:18

tomek2k1 requested review from a team and skjnldsv as code owners October 8, 2026 16:18

tomek2k1 requested review from Altahrim, kristian-zendato and pringelmann and removed request for a team October 8, 2026 16:18

tomek2k1 requested review from leftybournes, provokateurin and sorbaugh October 8, 2026 16:18

tomek2k1 force-pushed the feature/files-app4all branch from bcaa42e to ff3c1eb Compare October 8, 2026 16:28

feat(files): Make Files app reusable

4ff2f8f

Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de> Assisted-by: Copilot:Claude-Sonnet-5

tomek2k1 force-pushed the feature/files-app4all branch from 5ae36c5 to 4ff2f8f Compare October 8, 2026 20:35

artonge reviewed Oct 22, 2026

View reviewed changes

artonge requested a review from susnux October 22, 2026 09:23

susnux reviewed Oct 22, 2026

View reviewed changes

Merge branch 'master' into feature/files-app4all

2bcad0e

		Util::addInitScript('files', 'init');
		Util::addScript('files', 'main');

Conversation

tomek2k1 commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

AI (if applicable)

Uh oh!

marcoambrosini commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

artonge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tomek2k1 commented Sep 23, 2026 •

edited

Loading