chore(eslint): migrate to eslint 10

.nextcloudignore

@@ -3,8 +3,6 @@
 _config.yml
 .codecov.yml
 .drone.yml
-.eslintrc.js
-.eslintrc.yml
 .git
 .github
 .gitignore
@@ -19,6 +17,7 @@ composer.json
 composer.lock
 cypress
 cypress.config.ts
+eslint.config.mjs
 img/screenshots
 issue_template.md
 krankerl.toml

.stylelintrc.js

@@ -9,8 +9,8 @@ stylelintConfig.rules['no-invalid-position-at-import-rule'] = null
 stylelintConfig.rules['selector-pseudo-element-no-unknown'] = [
 	true,
 	{
-		ignorePseudoElements: ['v-deep']
-	}
+		ignorePseudoElements: ['v-deep'],
+	},
 ]
 
 module.exports = stylelintConfig

REUSE.toml

@@ -6,7 +6,7 @@ SPDX-PackageSupplier = "Nextcloud <info@nextcloud.com>"
 SPDX-PackageDownloadLocation = "https://github.com/nextcloud/richdocuments"
 
 [[annotations]]
-path = [".gitattributes", ".github/issue_template.md", ".github/CODEOWNERS", ".editorconfig", "package-lock.json", "package.json", "composer.json", "composer.lock", "**/composer.json", "**/composer.lock", ".l10nignore", "cypress/tsconfig.json", "vendor-bin/**/composer.json", "vendor-bin/**/composer.lock", ".tx/config", "tsconfig.json", "js/vendor.LICENSE.txt", "krankerl.toml", ".npmignore", ".nextcloudignore", ".eslintrc.json", ".tx/backport", "fonts/.gitkeep"]
+path = [".gitattributes", ".github/issue_template.md", ".github/CODEOWNERS", ".editorconfig", "package-lock.json", "package.json", "composer.json", "composer.lock", "**/composer.json", "**/composer.lock", ".l10nignore", "cypress/tsconfig.json", "vendor-bin/**/composer.json", "vendor-bin/**/composer.lock", ".tx/config", "tsconfig.json", "js/vendor.LICENSE.txt", "krankerl.toml", ".npmignore", ".nextcloudignore", ".tx/backport", "fonts/.gitkeep"]
 precedence = "aggregate"
 SPDX-FileCopyrightText = "none"
 SPDX-License-Identifier = "CC0-1.0"

cypress.config.ts

@@ -3,23 +3,22 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 import { defineConfig } from 'cypress'
+import setupPlugins from './cypress/plugins/index.js'
 
 export default defineConfig({
-  env: {
-    collaboraUrl: process.env.CYPRESS_collaboraUrl ?? 'https://localhost:9980/',
-  },
-  projectId: 'fef71b',
-  viewportWidth: 1280,
-  viewportHeight: 720,
-  chromeWebSecurity: false,
-  modifyObstructiveCode: false,
-  e2e: {
-    // We've imported your old cypress plugins here.
-    // You may want to clean this up later by importing these.
-    setupNodeEvents(on, config) {
-      return require('./cypress/plugins/index.js')(on, config)
-    },
-    baseUrl: 'https://localhost:8081/index.php/',
-    specPattern: 'cypress/e2e/**/*.{js,jsx,ts,tsx}',
-  },
+	env: {
+		collaboraUrl: process.env.CYPRESS_collaboraUrl ?? 'https://localhost:9980/',
+	},
+	projectId: 'fef71b',
+	viewportWidth: 1280,
+	viewportHeight: 720,
+	chromeWebSecurity: false,
+	modifyObstructiveCode: false,
+	e2e: {
+		setupNodeEvents(on, config) {
+			return setupPlugins(on, config)
+		},
+		baseUrl: 'https://localhost:8081/index.php/',
+		specPattern: 'cypress/e2e/**/*.{js,jsx,ts,tsx}',
+	},
 })

cypress/e2e/direct.spec.js

@@ -4,7 +4,7 @@
  */
 const baseUrl = Cypress.config('baseUrl').replace(/\/index.php\/?$/g, '')
 
-const getTemplates = (user, type) => {
+function getTemplates(user, type) {
 	return cy.request({
 		method: 'GET',
 		url: `${baseUrl}/ocs/v2.php/apps/richdocuments/api/v1/templates/${type}?format=json`,
@@ -13,14 +13,14 @@ const getTemplates = (user, type) => {
 			'OCS-ApiRequest': 'true',
 			'Content-Type': 'application/x-www-form-urlencoded',
 		},
-	}).then(response => {
+	}).then((response) => {
 		cy.log(response)
 		const templates = response.body?.ocs?.data
 		cy.wrap(templates)
 	})
 }
 
-const createDirectEditingLink = (user, fileId) => {
+function createDirectEditingLink(user, fileId) {
 	cy.login(user)
 	return cy.request({
 		method: 'POST',
@@ -34,37 +34,38 @@ const createDirectEditingLink = (user, fileId) => {
 			'OCS-ApiRequest': 'true',
 			'Content-Type': 'application/x-www-form-urlencoded',
 		},
-	}).then(response => {
+	}).then((response) => {
 		cy.log(response)
 		const token = response.body?.ocs?.data?.url
 		cy.log(`Created direct editing token for ${user.userId}`, token)
 		cy.wrap(token)
 	})
 }
 
-const createNewFileDirectEditingLink = (user, path, template) => {
+function createNewFileDirectEditingLink(user, path, template) {
 	cy.login(user)
 	return cy.request({
 		method: 'POST',
 		url: `${baseUrl}/ocs/v2.php/apps/richdocuments/api/v1/templates/new?format=json`,
 		form: true,
 		body: {
-			path, template,
+			path,
+			template,
 		},
 		// auth: { user: user.userId, pass: user.password },
 		headers: {
 			'OCS-ApiRequest': 'true',
 			'Content-Type': 'application/x-www-form-urlencoded',
 		},
-	}).then(response => {
+	}).then((response) => {
 		cy.log(response)
 		const token = response.body?.ocs?.data?.url
 		cy.log(`Created direct editing token for ${user.userId}`, token)
 		cy.wrap(token)
 	})
 }
 
-const createDirectEditingLinkForShareToken = (shareToken, host = undefined, path = '', password = undefined) => {
+function createDirectEditingLinkForShareToken(shareToken, host = undefined, path = '', password = undefined) {
 	cy.logout()
 	return cy.request({
 		method: 'POST',
@@ -81,10 +82,10 @@ const createDirectEditingLinkForShareToken = (shareToken, host = undefined, path
 			'OCS-ApiRequest': 'true',
 			'Content-Type': 'application/x-www-form-urlencoded',
 		},
-	}).then(response => {
+	}).then((response) => {
 		cy.log(response)
 		const token = response.body?.ocs?.data?.url
-		cy.log(`Created direct editing token for share link`, token)
+		cy.log('Created direct editing token for share link', token)
 		cy.wrap(token)
 	})
 }
@@ -93,7 +94,7 @@ describe('Direct editing (legacy)', function() {
 	let randUser
 
 	before(function() {
-		cy.createRandomUser().then(user => {
+		cy.createRandomUser().then((user) => {
 			randUser = user
 		})
 	})
@@ -204,14 +205,11 @@ describe('Direct editing (legacy)', function() {
 					cy.waitForCollabora(false)
 					cy.waitForPostMessage('App_LoadingStatus', { Status: 'Document_Loaded' })
 
-					cy.window().then(win => {
+					cy.window().then((win) => {
 						cy.spy(win.console, 'warn').as('consoleWarn')
 					})
 					cy.dispatchMessageFromOrigin('https://evil.example.com', { MessageId: 'Action_Save', Values: {} })
-					cy.get('@consoleWarn').should('have.been.calledWith',
-						'PostMessageService: rejected message from unexpected origin',
-						'https://evil.example.com'
-					)
+					cy.get('@consoleWarn').should('have.been.calledWith', 'PostMessageService: rejected message from unexpected origin', 'https://evil.example.com')
 				})
 		})
 
@@ -227,7 +225,7 @@ describe('Direct editing (legacy)', function() {
 					})
 					cy.waitForCollabora(false)
 					cy.waitForPostMessage('App_LoadingStatus', { Status: 'Document_Loaded' })
-					cy.get('[data-cy="coolframe"]').then($iframe => {
+					cy.get('[data-cy="coolframe"]').then(($iframe) => {
 						const collaboraOrigin = $iframe[0].contentWindow.location.origin
 						cy.spy($iframe[0].contentWindow, 'postMessage').as('postMessage')
 						cy.dispatchMessageFromOrigin(collaboraOrigin, { MessageId: 'Action_Paste', Values: {} })
@@ -238,10 +236,10 @@ describe('Direct editing (legacy)', function() {
 	})
 
 	it.skip('Open a remotely shared file', () => {
-		cy.createRandomUser().then(shareRecipient => {
+		cy.createRandomUser().then((shareRecipient) => {
 			cy.login(randUser)
 			cy.shareFileToRemoteUser(randUser, '/document.odt', shareRecipient)
-				.then(incomingFileId => {
+				.then((incomingFileId) => {
 					createDirectEditingLink(shareRecipient, incomingFileId)
 						.then((token) => {
 							cy.logout()
@@ -286,5 +284,4 @@ describe('Direct editing (legacy)', function() {
 				cy.closeDirectDocument()
 			})
 	})
-
 })

cypress/e2e/integration.spec.js

@@ -8,7 +8,7 @@ describe('Nextcloud integration', function() {
 
 	before(function() {
 		cy.nextcloudTestingAppConfigSet('richdocuments', 'uiDefaults-UIMode', 'notebookbar')
-		cy.createRandomUser().then(user => {
+		cy.createRandomUser().then((user) => {
 			randUser = user
 			cy.login(user)
 			cy.uploadFile(randUser, 'image.png', 'image/png', '/image.png')
@@ -111,8 +111,8 @@ describe('Nextcloud integration', function() {
 			cy.get('@shortcuts-bar').should('be.visible')
 
 			cy.get('@shortcuts-bar')
-			    .find('button[aria-label="Open in local editor"]')
-			    .click()
+				.find('button[aria-label="Open in local editor"]')
+				.click()
 		})
 
 		cy.get('.confirmation-dialog').should('be.visible')
@@ -125,7 +125,7 @@ describe('Nextcloud integration', function() {
 		}).as('getLocalToken')
 		cy.window()
 			.then((window) => {
-			  cy.stub(window, 'open').as('open')
+				cy.stub(window, 'open').as('open')
 			})
 		cy.get('.confirmation-dialog button:contains("Open locally")').click()
 		cy.wait('@getLocalToken').its('response.statusCode').should('equal', 200)

cypress/e2e/new.spec.js

@@ -4,10 +4,9 @@
  */
 
 describe('New file menu', function() {
-
 	let randUser
 	before(function() {
-		cy.createRandomUser().then(user => {
+		cy.createRandomUser().then((user) => {
 			randUser = user
 			cy.login(user)
 		})
@@ -35,7 +34,10 @@ describe('New file menu', function() {
 
 	describe('Creates a new file', function() {
 		const newFileTypeLabels = [
-			'document', 'spreadsheet', 'presentation', 'diagram',
+			'document',
+			'spreadsheet',
+			'presentation',
+			'diagram',
 		]
 
 		newFileTypeLabels.forEach((filetype) => {