Repository navigation
feat(api): describe recommended files as WebDAV does - #1206
Merged
Merged
Conversation
Add the etag, mtime, size, permissions, owner and share attributes, so a client can build the same node as from a PROPFIND. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
susnux
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommendations API only gave a file's id, name, folder and mime. A client that wants to open one in the viewer has to build an
@nextcloud/filesnode from that, and had to guess the permissions and download restrictions. It now also returns the etag, mtime, size, permissions, owner and share attributes, from the same sources as their WebDAV props.shareAttributesis what tells the viewer that a share forbids downloading. The frontend will use these once #1205 is in.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.