Skip to content

Shares fixes, refactoring and optimizations - #4544

Merged
dartcafe merged 5 commits into
mainfrom
fix/catch-failing-getUser
Mar 22, 2026
Merged

dartcafe merged 5 commits into
mainfrom
fix/catch-failing-getUser

Conversation

@dartcafe

@dartcafe dartcafe commented Mar 22, 2026 •

Copy link
Copy Markdown
Collaborator

This PR turned into a bigger refactoring and bugfix after a review regarding share usage.

  • eliminated a lot of db access by
    • caching of user objects i.E. instead of loading for every vote
    • Resolve share users directly from the share's properties in case of external shares
  • cleaning up session properties
  • Generate random names for anonymous users instead of naming them all Anon
  • Adding some more tests
  • ignore displayName for public share type and only use label
  • Some code simplification for better readability and use case separation

Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 9.0.0 milestone Mar 22, 2026
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
dartcafe merged commit 3ca7c38 into main Mar 22, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant