Skip to content

Fix calculation of all day durations #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dartcafe merged 3 commits into from
Nov 30, 2025
Merged

Fix calculation of all day durations #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
702bc1f
fix duration
dartcafe Nov 30, 2025
703d303
typo
dartcafe Nov 30, 2025
9fdc057
change log add known bug
dartcafe Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@
All notable changes to this project will be documented in this file.

## [unreleased]
### Known bugs
- Options of date polls spanning a DST change may result in miscalculated durations

### Fixed
- Changed sql query to be ansi safe
- Cloning polls
- Fix all day duration calculation of date polls

### Added
- Show locale date as tooltip for relative date time information
Expand Down
7 changes: 2 additions & 5 deletions src/components/Base/modules/DateBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,10 @@ const allDay = computed(
// subtract a day if allDay is true and luxonDuration is greater than 0 to match the
// end of the day after the duration instead of the beginning of the next day
const to = computed(() => {
// this is a quick fix which intercepts dayspans crossing daylight saving time changes
// Adding duration as seconds divided by a normal dayspan in seconds (86400) multiplied
// by 86400 ensures that we always land at the same time of day, even if the actual
// dayspan is 23 or 25 hours due to DST changes
// FIXME: this should be replaced by a more stable solution
// The last change reintroduced the DST bug (see #4276)
if (allDay.value) {
return dateTime.plus((duration.as('seconds') / 86400) * 86400)
return dateTime.plus(duration)
}
return dateTime
.plus(duration)
Expand Down