Repository navigation
[stable34] chore(deps): combine pending dependency updates - #4030
Merged
Merged
Conversation
skjnldsv
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
skjnldsv
enabled auto-merge
October 27, 2026 11:31
Since 6.19.0, on PHP older than 8.5, psalm preloads its stub of the classes newer PHP versions bring next to the stubs a project preloads. With both preloaded, it no longer sees that the stubbed SearchBinaryOperator is an ISearchOperator through ISearchBinaryOperator, and flags the two places that hand one to SearchQuery: InvalidArgument: Argument 1 of OC\Files\Search\SearchQuery::__construct expects OCP\Files\Search\ISearchOperator, but OC\Files\Search\SearchBinaryOperator provided The CI runs psalm on PHP 8.3 and picks up its latest 6.x, so every pull request failed it. Naming ISearchOperator on the stub class as well holds on both PHP 8.3 and 8.5. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com> (cherry picked from commit 8892ce2)
Signed-off-by: GitHub <noreply@github.com> (cherry picked from commit 397f383)
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
chore/deps-stable34
branch
from
October 27, 2026 19:29
1831a20 to
a24c399
Compare
susnux
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the psalm stub fix from master (8892ce2), which #4022 and #3873 fail on, and brings #4022 along. Plus an npm audit fix.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.