Repository navigation
[stable35] fix(tags): read the tag id from the node instead of its attributes - #3871
Draft
backportbot[bot] wants to merge 3 commits into
Draft
backportbot[bot] wants to merge 3 commits into
backportbot[bot] wants to merge 3 commits into
Conversation
backportbot
Bot
added
bug
skjnldsv
force-pushed
the
backport/3863/stable35
branch
from
October 16, 2026 07:52
36c6586 to
568642d
Compare
skjnldsv
approved these changes
Oct 16, 2026
skjnldsv
force-pushed
the
backport/3863/stable35
branch
from
October 16, 2026 13:28
568642d to
6bf54b8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The tags view has shown "No tags yet" for every account since the bump to @nextcloud/files 4.0.0 (41ed241). The Node class gained an `id` getter, and a Node refuses to store an attribute named after one of its getters, so the `oc:id` property the systemtags-assigned listing answers was silently dropped and `tag.attributes.id` became undefined for every tag. The view then filtered every tag out. The id is now handed to the Node as the file id it reads its own `id` from, and the store keys tags by that `id`. Since Node ids are strings, the tag ids of the store and the services follow. The listing also leads with the collection itself, which the client does not strip and which used to be discarded by the very same attribute check. It is now filtered out before turning the entries into tags. Assisted-by: ClaudeCode:claude-fable-5-1 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
test(e2e): cover the tags view The overview listing a tag with its photo count, the photos of a tag and no other, opening one in the viewer, the way back to the overview and the empty state. Fails without the fix of the previous commit. Assisted-by: ClaudeCode:claude-fable-5-1 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
backport/3863/stable35
branch
from
October 16, 2026 23:50
3eb5b88 to
055913c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3863
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.