Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Only one tab per browser polls, handles notify_push and registers web push. Other tabs receive the data over a BroadcastChannel and do not fetch on load. Without Web Locks (insecure context) every tab polls on its own. Notification data is no longer cached in localStorage. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
commented
Oct 30, 2026
| handleNetworkOnline() { | ||
| this._fetch() | ||
| if (this.isLeader) { | ||
| this._fetch() |
Collaborator
Author
There was a problem hiding this comment.
could steal the leadership
Antreesy
commented
Oct 30, 2026
| @@ -355,7 +364,6 @@ export default { | |||
| }) | |||
| } | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
could steal the leadership
Antreesy
commented
Oct 30, 2026
| onData(event.data) | ||
| } | ||
| navigator.locks.request(name, () => { | ||
| isLeader.value = true |
Collaborator
Author
There was a problem hiding this comment.
- should generate a console.debug
- should handle the stealing, downgrade leadership and request again
- should broadcast polling interval between all windows
Antreesy
commented
Oct 30, 2026
| import './styles/styles.scss' | ||
| import '@nextcloud/dialogs/style.css' | ||
|
|
||
| // TODO: remove in v37. Notifications were cached in the browser storage before v36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes notifications data storage and exchanges between multiple tabs:
Webpush only:
Known issues:
🤖 AI (if applicable)